On Fri, Sep 06, 2013 at 11:29:17AM -0700, Sudeep Dutt wrote: > On Thu, 2013-09-05 at 21:58 -0700, Greg Kroah-Hartman wrote: > > Again, very minor fixups for later (I can even do them...) > > > > > +static DEVICE_ATTR(state, S_IRUGO|S_IWUSR, mic_show_state, mic_store_state); > > > > DEVICE_ATTR_RW() please. > > > > Same for the other attributes you create in this patch. > > > > Sure, we will incorporate these changes along with your other feedback > in patch 1 and post the next revision of this patch series. There's no need to repost just yet. I can take these as-is after the merge window closes, and you can send follow-on patches for these minor issues, keeping you from having to do a respin, and me trying to remember what parts I reviewed and didn't review. So give me some time (i.e. wait for after 3.12-rc1 is out) and if I have further problems with the patches, I'll let you know, otherwise you'll get an automated email from my patch collection system saying the patches are applied. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
