On 07/11/2023 11:39, Billy Tsai wrote: > Unlike the old design that the register setting of the TACH should based > on the configure of the PWM. In ast26xx, the dependency between pwm and > tach controller is eliminated and becomes a separate hardware block. One > is used to provide pwm output and another is used to monitor the frequency > of the input. This driver implements them by exposing two kernel > subsystems: PWM and HWMON. The PWM subsystem can be utilized alongside > existing drivers for controlling elements such as fans (pwm-fan.c), > beepers (pwm-beeper.c) and so on. Through the HWMON subsystem, the driver > provides sysfs interfaces for fan. > > Changes since v9: > Change the type of fan-driving-mode to string > Fix some typos and formatting issues. Please run scripts/checkpatch.pl and fix reported warnings. Some warnings can be ignored, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Best regards, Krzysztof
