Hi Ivan, kernel test robot noticed the following build warnings: [auto build test WARNING on tiwai-sound/for-next] [also build test WARNING on tiwai-sound/for-linus linus/master v6.6 next-20231103] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Ivan-Orlov/ALSA-Add-new-driver-for-Marian-M2-sound-card/20230919-021236 base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next patch link: https://lore.kernel.org/r/20230918181044.7257-2-ivan.orlov0322%40gmail.com patch subject: [PATCH v2 2/2] ALSA: Add new driver for Marian M2 sound card config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20231106/202311060403.591giMV8-lkp@xxxxxxxxx/config) compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231106/202311060403.591giMV8-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202311060403.591giMV8-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): sound/pci/marianm2.c:466:6: warning: variable 'buffer_frames' set but not used [-Wunused-but-set-variable] int buffer_frames; ^ >> sound/pci/marianm2.c:472:11: warning: variable 'speedmode' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] else if (params_rate(params) < RATE_FAST) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sound/pci/marianm2.c:475:6: note: uninitialized use occurs here if (speedmode > marian->desc->speedmode_max) { ^~~~~~~~~ sound/pci/marianm2.c:472:7: note: remove the 'if' if its condition is always true else if (params_rate(params) < RATE_FAST) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sound/pci/marianm2.c:465:24: note: initialize the variable 'speedmode' to silence this warning unsigned int speedmode; ^ = 0 2 warnings generated. vim +472 sound/pci/marianm2.c 460 461 static int snd_marian_hw_params(struct snd_pcm_substream *substream, 462 struct snd_pcm_hw_params *params) 463 { 464 struct marian_card *marian = snd_pcm_substream_chip(substream); 465 unsigned int speedmode; > 466 int buffer_frames; 467 468 buffer_frames = SUBSTREAM_BUF_SIZE / M2_FRAME_SIZE; 469 470 if (params_rate(params) < RATE_SLOW) 471 speedmode = SPEEDMODE_SLOW; > 472 else if (params_rate(params) < RATE_FAST) 473 speedmode = SPEEDMODE_FAST; 474 475 if (speedmode > marian->desc->speedmode_max) { 476 dev_err(marian->card->dev, 477 "Requested rate (%u Hz) higher than card's maximum\n", 478 params_rate(params)); 479 _snd_pcm_hw_param_setempty(params, SNDRV_PCM_HW_PARAM_RATE); 480 return -EBUSY; 481 } 482 483 spin_lock(&marian->reglock); 484 if (marian->desc->set_speedmode) 485 marian->desc->set_speedmode(marian, speedmode); 486 else 487 marian_generic_set_speedmode(marian, speedmode); 488 489 marian->detune = 0; 490 491 marian_generic_set_dco(marian, params_rate(params), 0); 492 spin_unlock(&marian->reglock); 493 494 if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) 495 snd_pcm_set_runtime_buffer(substream, &marian->playback_buf); 496 else 497 snd_pcm_set_runtime_buffer(substream, &marian->capture_buf); 498 499 // apply optional card specific hw constraints 500 if (marian->desc->hw_constraints_func) 501 marian->desc->hw_constraints_func(marian, substream, params); 502 503 return 0; 504 } 505 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
