On 10/26/23 03:41, Ellie Hermaszewska wrote:
On 10/26/23 13:01, Guenter Roeck wrote:
On 10/25/23 21:46, Ellie Hermaszewska wrote:
On 10/26/23 03:35, Guenter Roeck wrote:
> This is not an acceptable commit description.
This is not acceptable feedback.
I am unable to accept it because it is not clear to me what you think
should be changed.
Is it because I misplaced the message to Eugene? Is it because of the
Greek characters? Is is not descriptive enough of the change, or in the
wrong tense, or has incorrect punctuation? Do I need to include my
testing methodology?
If it's only something minor, then please also feel free to correct it
yourself before applying. If you can't or it's not something minor,
then please let me know what ought to change and I can try to correct it.
If you don't let me know, then I will have to guess and possibly waste everyone's time further.
Please consider reading and following the directions in
Documentation/process/submitting-patches.rst.
I will guess that it was my misplaced reply, and submit again without that part.
From the document:
> Other comments relevant only to the moment or the maintainer, not
> suitable for the permanent changelog, should also go here. A good
> example of such comments might be ``patch changelogs`` which describe
> what has changed between the v1 and v2 version of the patch.
> Please put this information **after** the ``---`` line which separates
> the changelog from the rest of the patch. The version information is
> not part of the changelog which gets committed to the git tree. It is
> additional information for the reviewers. If it's placed above the
> commit tags, it needs manual interaction to remove it. If it is below
> the separator line, it gets automatically stripped off when applying the
> patch::
> ...
> [ ... ] When sending a next
> version, add a ``patch changelog`` to the cover letter or to individual patches
> explaining difference against previous submission
Keeping the patch description clean does not mean to _drop_ the changelog
or additional information not intended to be added to the commit.
Guenter
