Re: [PATCH v16 04/12] block: add emulation for copy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 26/09/23 03:37PM, Nitesh Jagadeesh Shetty wrote:
+                write_bio->bi_iter.bi_size = chunk;
+                ret = submit_bio_wait(write_bio);
+                kfree(write_bio);

blk_mq_map_bio_put(write_bio) ?
or bio_uninit(write_bio); kfree(write_bio)?

hmm...
It continuously allocates and releases memory for bio,
Why don't you just allocate and reuse bio outside the loop?


Agree, we will update this in next version.

Reusing the bio won't work in cases where the bio gets split.
So we decided to keep the previous design.

Thank you,
Nitesh Shetty





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux