On Tue, 17 Oct 2023 13:03:39 -0700 Alexander Duyck wrote: > > > My thought would be to possibly just look at reducing your messaging > > > to a warning from the driver if the inputs are not symmetric, but you > > > have your symmetric xor hash function enabled. > > > > With the restrictions (to be moved into ice_ethtool), the user is unable > > to use non-symmetric inputs. > > I think a warning would make more sense than an outright restriction. > You could warn on both the enabling if the mask is already unbalanced, > or you could warn if the mask is set to be unbalanced after enabling > your hashing. Either it's a valid configuration or we should error out in the core. Keep in mind that we can always _loosen_ the restriction, like you asked for VLAN ID, but we can never _tighten_ it without breaking uAPI. So error.
