On Fri, 13 Oct 2023 19:14:46 +0300 Vladimir Oltean wrote: > > What is "PRECISION"? DMA is a separate block like MAC and PHY. > > If DMA is a separate block like MAC and PHY, can it have its own PHC > device, and the ethtool UAPI only lists the timestamping-capable PHCs > for one NIC, and is able to select between them? Possibly, I guess. There are some devices which use generic (i.e. modeled by Linux as separate struct device) DMA controllers to read out packets from "MAC" FIFOs. In practice I'm not sure if any of those DMA controllers has time stamping capabilities. > Translation between the UAPI-visible PHC index and MAC, DMA, phylib > PHY, other PHY etc can then be done by the kernel as needed. Translation by the kernel at which point? IMHO it'd indeed be clearer for the user to have an ability to read the PHC for SOF_..._DMA via ETHTOOL_MSG_TS_LIST_GET_REPLY as a separate entry, rather than e.g. assume that DMA uses the same PHC as MAC.