On Tue, 10 Oct 2023 17:37:47 +0200 Simon Horman <horms@xxxxxxxxxx> wrote: > ... > > > diff --git a/drivers/net/phy/nxp-c45-tja11xx.c > > b/drivers/net/phy/nxp-c45-tja11xx.c index 7ab080ff02df..416484ea6eb3 100644 > > --- a/drivers/net/phy/nxp-c45-tja11xx.c > > +++ b/drivers/net/phy/nxp-c45-tja11xx.c > > @@ -1022,24 +1022,21 @@ static bool nxp_c45_rxtstamp(struct mii_timestamper > > *mii_ts, } > > > > static int nxp_c45_hwtstamp(struct mii_timestamper *mii_ts, > > - struct ifreq *ifreq) > > + struct kernel_hwtstamp_config *config, > > + struct netlink_ext_ack *extack) > > { > > struct nxp_c45_phy *priv = container_of(mii_ts, struct nxp_c45_phy, > > mii_ts); > > struct phy_device *phydev = priv->phydev; > > const struct nxp_c45_phy_data *data; > > - struct hwtstamp_config cfg; > > > > - if (copy_from_user(&cfg, ifreq->ifr_data, sizeof(cfg))) > > - return -EFAULT; > > - > > - if (cfg.tx_type < 0 || cfg.tx_type > HWTSTAMP_TX_ON) > > + if (cfg->tx_type < 0 || cfg->tx_type > HWTSTAMP_TX_ON) > > Hi Köry, > > cfg is removed from this function by this patch, but is used here. Thanks for your review. Indeed there is a mistake here. It will be fixed it next version.