On Mon, 9 Oct 2023 14:21:42 -0700 Florian Fainelli <florian.fainelli@xxxxxxxxxxxx> wrote: > On 10/9/23 08:51, Köry Maincent wrote: > > From: Kory Maincent <kory.maincent@xxxxxxxxxxx> > > > > Add a new commands allowing to get the current time stamping on a > > netdevice's link. > > > > Example usage : > > ./ynl/cli.py --spec netlink/specs/ethtool.yaml --no-schema --do ts-get \ > > --json '{"header":{"dev-name":"eth0"}}' > > {'header': {'dev-index': 3, 'dev-name': 'eth0'}, 'ts-layer': 1} > > > > Signed-off-by: Kory Maincent <kory.maincent@xxxxxxxxxxx> > > This is small enough you could probably fold this patch into patch 8. I like having it separate. Indeed the ynl tool does not have a proper usage documentation. I took quite some times to me to understand how use it especially with bitset. Using the commit messages to add examples like that would have help me a lot in the process. I could also squash the example in the previous commit message but then it become more noisy. What do you think?