Hi Babu, On 10/3/2023 4:54 PM, Babu Moger wrote: > Files unique to monitoring groups have the RFTYPE_MON flag. When a new > monitoring group is created the resctrl files with flags RFTYPE_BASE > (files common to all resource groups) and RFTYPE_MON (files unique to > monitoring groups) are created to support interacting with the new > monitoring group. > > A resource group can support both monitoring and control, also termed > a CTRL_MON resource group. CTRL_MON groups should get both monitoring > and control resctrl files but that is not the case. Only the > RFTYPE_BASE and RFTYPE_CTRL files are created for CTRL_MON groups. > This is not a problem because there are no monitoring specific files > with the RFTYPE_MON flag associated with resource groups. > > A later patch introduces the first monitoring specific (RFTYPE_MON) > file for resource groups. Ensure that files with the RFTYPE_MON > flag are created for CTRL_MON groups. > > Signed-off-by: Babu Moger <babu.moger@xxxxxxx> > Tested-by: Peter Newman <peternewman@xxxxxxxxxx> > Reviewed-by: Peter Newman <peternewman@xxxxxxxxxx> > Tested-by: Tan Shaopeng <tan.shaopeng@xxxxxxxxxxxxxx> > Reviewed-by: Tan Shaopeng <tan.shaopeng@xxxxxxxxxxxxxx> > Reviewed-by: Fenghua Yu <fenghua.yu@xxxxxxxxx> > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> > --- Thank you. Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx> I believe this series is ready for inclusion. There is a conflict between this series and Maciej's non-contiguous work [1] that is also ready for inclusion. We could wait for outcome of next level review to determine who will need to rebase. It may help to provide a snippet of the conflict resolution in anticipation of Maciej's series being merged first (I will propose the same to Maciej for the scenario of this work merged first). Reinette [1] https://lore.kernel.org/lkml/cover.1696493034.git.maciej.wieczor-retman@xxxxxxxxx/
