Re: [PATCH v10 03/10] x86/resctrl: Rename rftype flags for consistency

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Reinette,

On 9/27/2023 1:31 PM, Reinette Chatre wrote:
Hi Babu,

On 9/15/2023 3:42 PM, Babu Moger wrote:
resctrl associates rftype flags with its files so that files can be chosen
based on the resource, whether it is info or base, and if it is control
or monitor type file. These flags use the RF_ as well as RFTYPE_ prefixes.

Change the prefix to RFTYPE_ for all these flags to be consistent.

Also add the flag RFTYPE_MON_BASE, which contains the files required for
MON group only.
This appears to be appending an unexpected (because it introduces an unused flag)
change without motivation as an afterthought.

How about:
	Add RFTYPE_MON_BASE that will be used in a later patch. RFTYPE_MON_BASE
	complements existing RFTYPE_CTRL_BASE and represents files
	belonging to monitoring groups.

Looks good.



Feel free to improve.

Signed-off-by: Babu Moger <babu.moger@xxxxxxx>
---
The patch looks good. With the changelog cleared up:

Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>

Thanks

Babu




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux