Hi Arkadiusz, kernel test robot noticed the following build warnings: [auto build test WARNING on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Arkadiusz-Kubalewski/dpll-docs-add-support-for-pin-signal-phase-offset-adjust/20230927-172843 base: net-next/main patch link: https://lore.kernel.org/r/20230927092435.1565336-5-arkadiusz.kubalewski%40intel.com patch subject: [PATCH net-next 4/4] ice: dpll: implement phase related callbacks config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20230927/202309272113.rttl6e6s-lkp@xxxxxxxxx/config) compiler: alpha-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230927/202309272113.rttl6e6s-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202309272113.rttl6e6s-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> drivers/net/ethernet/intel/ice/ice_dpll.c:1064: warning: Function parameter or member 'phase_offset' not described in 'ice_dpll_phase_offset_get' >> drivers/net/ethernet/intel/ice/ice_dpll.c:1064: warning: Excess function parameter 'phase_adjust' description in 'ice_dpll_phase_offset_get' vim +1064 drivers/net/ethernet/intel/ice/ice_dpll.c 1039 1040 #define ICE_DPLL_PHASE_OFFSET_DIVIDER 100 1041 #define ICE_DPLL_PHASE_OFFSET_FACTOR \ 1042 (DPLL_PHASE_OFFSET_DIVIDER / ICE_DPLL_PHASE_OFFSET_DIVIDER) 1043 /** 1044 * ice_dpll_phase_offset_get - callback for get dpll phase shift value 1045 * @pin: pointer to a pin 1046 * @pin_priv: private data pointer passed on pin registration 1047 * @dpll: registered dpll pointer 1048 * @dpll_priv: private data pointer passed on dpll registration 1049 * @phase_adjust: on success holds pin phase_adjust value 1050 * @extack: error reporting 1051 * 1052 * Dpll subsystem callback. Handler for getting phase shift value between 1053 * dpll's input and output. 1054 * 1055 * Context: Acquires pf->dplls.lock 1056 * Return: 1057 * * 0 - success 1058 * * negative - error 1059 */ 1060 static int 1061 ice_dpll_phase_offset_get(const struct dpll_pin *pin, void *pin_priv, 1062 const struct dpll_device *dpll, void *dpll_priv, 1063 s64 *phase_offset, struct netlink_ext_ack *extack) > 1064 { 1065 struct ice_dpll *d = dpll_priv; 1066 struct ice_pf *pf = d->pf; 1067 1068 mutex_lock(&pf->dplls.lock); 1069 if (d->active_input == pin) 1070 *phase_offset = d->phase_offset * ICE_DPLL_PHASE_OFFSET_FACTOR; 1071 else 1072 *phase_offset = 0; 1073 mutex_unlock(&pf->dplls.lock); 1074 1075 return 0; 1076 } 1077 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
