>> Create separate domain lists for control and monitor operations. >> >> No important functional change. But note that errors during > > Its better to remove the line "No important functional change." Will drop it. >> struct list_head domains; >> + struct list_head mondomains; > > For consistancy, its better to rename it to mon_domains(to be inline with > mon_scope, mon_capable). Again, you are thinking like Reinette! You'll be a resctrl maintainer soon. >> +struct rdt_domain *rdt_find_ctrldomain(struct list_head *h, int id, >> + struct list_head **pos); >> +struct rdt_domain *rdt_find_mondomain(struct list_head *h, int id, >> + struct list_head **pos); > > For consistancy, it is better to rename to rdt_find_ctrl_domain and > rdt_find_mon_domain respectively. Agreed. Thanks for the review. -Tony
