On Mon, Sep 18, 2023 at 9:00 PM Dmitry Safonov <dima@xxxxxxxxxx> wrote: > > Hi, > > This is version 12 of TCP-AO support. The changes from v11 address > Eric's review comments. The biggest change was defining a common > (struct tcp_key) that merges tcp_ao_key with tcp_md5sig_key on TCP > fast-path, therefore in order to help reviewing I provide > the ranged-diff between the versions here: > > https://gist.github.com/0x7f454c46/fe546b9cf323ca21acc3d0eabbd41236 > > There's one Sparse warning introduced by tcp_sigpool_start(): > __cond_acquires() seems to currently being broken. I've described > the reasoning for it on v9 cover letter. Also, checkpatch.pl warnings > were addressed, but yet I've left the ones that are more personal > preferences (i.e. 80 columns limit). Please, ping me if you have > a strong feeling about one of them. > > The following changes since commit a5ea26536e89d04485aa9e1c8f60ba11dfc5469e: > > Merge branch 'stmmac-devvm_stmmac_probe_config_dt-conversion' (2023-09-18 12:44:36 +0100) Sorry for the delay, but I was looking at a bug in TCP MD5. I will ask you to fix it, before we change everything in the stack related to MD5 :/ I am releasing a syzbot report right now, I will CC you on it.
