Hi Andrew, On 14/09/23 7:25 am, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >> +#define REG_STDR_RESET 0x00000003 > > This appears to be a standard register, so you should not need to > define it here. Ah ok, will do it. > >> +#define REG_MAC_ADDR_BO 0x00010022 >> +#define REG_MAC_ADDR_L 0x00010024 >> +#define REG_MAC_ADDR_H 0x00010025 >> +#define REG_MAC_NW_CTRL 0x00010000 >> +#define REG_MAC_NW_CONFIG 0x00010001 >> +#define REG_MAC_HASHL 0x00010020 >> +#define REG_MAC_HASHH 0x00010021 >> +#define REG_MAC_ADDR_BO 0x00010022 >> +#define REG_MAC_ADDR_L 0x00010024 >> +#define REG_MAC_ADDR_H 0x00010025 >> + >> +#define CCS_Q0_TX_CFG 0x000A0081 >> +#define CCS_Q0_RX_CFG 0x000A0082 > > These are proprietary vendor registers, so please add a prefix to make > this clear. Sure, will add it in the next version. Best Regards, Parthiban V > > Andrew