René Nyffenegger <mail@xxxxxxxxxxxxxxxxxx> writes: > On 9/1/23 16:22, Jonathan Corbet wrote: >> René Nyffenegger <mail@xxxxxxxxxxxxxxxxxx> writes: >> >>> The file include/linux/container_of.h contained kernel-doc but was not >>> referenced in any .rst file. In addition, the file >>> Documentation/core-api/kobject.rst wrongly located the definition >>> of the macro `container_of` in linux/kernel.h while in reality >>> it is defined in linux/container_of.h >>> >>> This patch adds a new .rst file that includes the kernel-doc of >>> container_of.h and rectifies the wrong reference of the header >>> file. >>> >>> Signed-off-by: René Nyffenegger <mail@xxxxxxxxxxxxxxxxxx> >> Thank you for working to improve the kernel documentation! >> >> There are, though, a few problems with this patch that will need to be >> addressed before it can be accepted. To start, please cc the maintainer >> (i.e. me) on documentation changes. >> > Thanks for looking at my attempt to patch the documentations. > > I tried to create an improved patch: > https://lore.kernel.org/linux-doc/20230902210422.8092-1-mail@xxxxxxxxxxxxxxxxxx/T/ > > However, I did not receive any feedback. So, I am wondering if I am > still making mistakes. In order to improve, I'd appreciate a feedback > what I need to change to create the patch. Sorry, I do have feedback, but between the merge window and travel I've fallen behind on things. I'll get there, honest. Thanks, jon