Hi Andrew, On 09/09/23 7:03 pm, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Fri, Sep 08, 2023 at 07:59:14PM +0530, Parthiban Veerasooran wrote: >> Implement register read/write interface according to the control >> communication specified in the OPEN Alliance 10BASE-T1x MACPHY Serial >> Interface document. Control transactions consist of one or more control >> commands. Control commands are used by the SPI host to read and write >> registers within the MAC-PHY. Each control commands are composed of a >> 32-bit control command header followed by register data. >> >> Control write commands can write either a single register or multiple >> consecutive registers. When multiple consecutive registers are written, >> the address is automatically post-incremented by the MAC-PHY. The write >> command and data is also echoed from the MAC-PHY back to the SPI host to >> enable the SPI host to identify which register write failed in the case >> of any bus errors. >> >> Control read commands can read either a single register or multiple >> consecutive registers. When multiple consecutive registers are read, the >> address is automatically post-incremented by the MAC-PHY. >> >> The register data being read or written can be protected against simple >> bit errors. When enabled by setting the Protection Enable (PROTE) bit in >> the CONFIG0 register, protection is accomplished by duplication of each >> 32-bit word containing register data with its ones’ complement. Errors >> are detected at the receiver by performing a simple exclusive-OR (XOR) of >> each received 32-bit word containing register data with its received >> complement and detecting if there are any zeros in the result. >> >> Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@xxxxxxxxxxxxx> >> --- >> Documentation/networking/oa-tc6-framework.rst | 231 ++++++++++++++++++ >> MAINTAINERS | 8 + >> drivers/net/ethernet/oa_tc6.c | 222 +++++++++++++++++ >> include/linux/oa_tc6.h | 31 +++ > > I'm surprised there is no kconfig and Makefile changes here. I would > expect this is compiled as a module, which the vendor code can then > make use of. Ok, actually this framework is used by vendor specific driver (lan865x.c) later with the Makefile update like below in the directory drivers/net/ethernet/microchip/, obj-$(CONFIG_LAN865X) += lan865x_t1s.o lan865x_t1s-objs := lan865x.o ../oa_tc6.o If I understand you correctly, this framework has to include the module initialization as well using the below APIs and has to be compiled as a loadable module so that other vendors module can make use of this, isn't it? module_init(oa_tc6_init); module_exit(oa_tc6_exit); Best Regards, Parthiban V > > Andrew >
