Re: [PATCH 1/2] dt-bindings: hwmon: Describe changes to the device tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/09/2023 10:37, Daniel Matyas wrote:
> Added new attributes to the device tree:

Subject: it's meaningless. You said there absolutely nothing. Instead
saying "Describe changes to the device tree" please describe the changes
you are making.

> 	- adi,comp-int
> 	- adi,alrm-pol
> 	- adi,flt-q
> 
> These modify the corresponding bits in the configuration register.
> 
> Signed-off-by: Daniel Matyas <daniel.matyas@xxxxxxxxxx>
> ---
>  .../bindings/hwmon/adi,max31827.yaml          | 21 +++++++++++++++++++

Please work on latest upstream, not some old vendor code. This means
that you should checkout latest mainline tree (or linux-next or
maintainer's tree) and make your edits there. Once you do it, you use
get_maintainers.pl on that tree, not on that ancient vendor's stuff.

Best regards,
Krzysztof




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux