On 08/09/2023 16:29, Parthiban Veerasooran wrote: > Add device-tree support for Microchip's LAN865X MACPHY for configuring > the OPEN Alliance 10BASE-T1x MACPHY Serial Interface parameters. Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. > > Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@xxxxxxxxxxxxx> > --- > .../bindings/net/microchip,lan865x.yaml | 54 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/microchip,lan865x.yaml > > diff --git a/Documentation/devicetree/bindings/net/microchip,lan865x.yaml b/Documentation/devicetree/bindings/net/microchip,lan865x.yaml > new file mode 100644 > index 000000000000..3465b2c97690 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/microchip,lan865x.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/microchip,lan865x.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Microchip LAN8650/1 10BASE-T1S MACPHY Ethernet Controllers > + > +maintainers: > + - Parthiban Veerasooran <parthiban.veerasooran@xxxxxxxxxxxxx> > + > +description: | > + Device tree properties for LAN8650/1 10BASE-T1S MACPHY Ethernet Drop "Device tree properties for" and instead describe the hardware. > + controller. > + > +allOf: > + - $ref: ethernet-controller.yaml# > + > +properties: > + compatible: > + items: No need for items. Just enum. > + - enum: > + - microchip,lan865x No wildcards in compatibles. Missing blank line. > + reg: > + maxItems: 1 > + > + local-mac-address: true > + oa-chunk-size: true > + oa-tx-cut-through: true > + oa-rx-cut-through: true > + oa-protected: true What are all these? Where are they defined that you skip description, type and vendor prefix? > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethernet@1{ Missing space > + compatible = "microchip,lan865x"; > + reg = <1>; /* CE0 */ CE0? chip-select? What does this comment mean in this context? > + local-mac-address = [04 05 06 01 02 03]; > + oa-chunk-size = <64>; > + oa-tx-cut-through; > + oa-rx-cut-through; > + oa-protected; Best regards, Krzysztof
