On 9/7/23 09:16, Nitesh Shetty wrote:
On 07/09/23 07:49AM, Hannes Reinecke wrote:
On 9/6/23 18:38, Nitesh Shetty wrote:
Hmm. That looks a bit odd. Why do you have to use wait_for_completion?
wait_for_completion is waiting for all the copy IOs to complete,
when caller does not pass endio handler.
Copy IO submissions are still async, as in previous revisions.
Can't you submit the 'src' bio, and then submit the 'dst' bio from the
endio handler of the 'src' bio?
We can't do this with the current bio merging approach.
'src' bio waits for the 'dst' bio to arrive in request layer.
Note that both bio's should be present in request reaching the driver,
to form the copy-cmd.
Hmm. I guess it would be possible, but in the end we can always change
it later once the infrastructure is in.
So:
Reviewed-by: Hannes Reinecke <hare@xxxxxxx>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@xxxxxxx +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman
