Hi Reinette, On 8/4/23 15:42, Reinette Chatre wrote: > Hi Babu, > > On 7/19/2023 4:22 PM, Babu Moger wrote: >> @@ -2591,6 +2599,8 @@ static int rdt_get_tree(struct fs_context *fc) >> out_schemata_free: >> schemata_list_destroy(); >> out_ctx: >> + if (ctx->enable_debug) >> + resctrl_debug = false; >> if (ctx->enable_mba_mbps) >> set_mba_sc(false); >> cdp_disable_all(); > > These changes are a red flag to me. Developers still need to > do what patch #4 was aiming to prevent. I think you meant patch 5 (x86/resctrl: Unwind the errors inside rdt_enable_ctx). I can take care of this unwind part in rdt_disable_ctx() and call it here. https://lore.kernel.org/lkml/9fd70ef3-ca90-65e3-4746-7d574bdd159b@xxxxxxxxx/#t Hope that is what you meant. -- Thanks Babu Moger
