The 'bindings' crate currently doesn't have API documentation available. With this change, it will be generated as part of the output of 'make rustdoc' (similar to the 'kernel' crate's docs, https://rust-for-linux.github.io/docs/kernel/). This patch is a RFC because there are a few questions: 1. Do we want to make this the default, or a separate target/ configuration? I don't think there is much downside to always generating. 2. The entire '.config' file could be included in the doc output, to make it easy to tell what settings the documentation was generated with. Would this be desired? Maybe with a '--cfg include-dotcfg=".config"' flag so published docs would have the option (unsure whether it may ever have sensitive information). Bindgen is currently invoked with '--no-doc-comments', I think this may be because some blocks were mistakenly interpreted as doctests. Once we upgrade our bindgen version we might be able to remove this. Side note, 'rust/Makefile' seems to have a mix of tabs and spaces - is this intentional? Trevor Gross (2): rust: bindings: generate API documentation for the 'bindings' crate rust: bindings: add warning about configuration dependence rust/Makefile | 14 +++++++++++--- rust/bindings/lib.rs | 3 +++ 2 files changed, 14 insertions(+), 3 deletions(-) -- 2.34.1
