On Thu, Jul 13, 2023 at 06:01:37PM -0700, Ilkka Koskinen wrote: > Changes since v4: > * "Support implementation specific filters" patch: > - Added comment about filter and impdef registers and reference > to the Coresight PMU specification to the commit message > > * "Add support for Ampere SoC PMU" patch: > - Fixed the documentation and added more comments > - Changed the incrementing PMU index number to idr_alloc() > (Needs a impdef release hook patch to release unused index) > - Fixed style in init_ops() to more reasonable > - Moved bank parameter to config1 This looks pretty good to me, but I think we should merge the series reworking the backend registration first: https://lore.kernel.org/all/20230705104745.52255-1-bwicaksono@xxxxxxxxxx/ and then this should slot in quite nicely. I've left a minor comment over there and I'd like Suzuki's review, but then we're good to go. Cheers, Will
