Hi Reinette, On 7/7/23 16:45, Reinette Chatre wrote: > Hi Babu, > > On 6/1/2023 12:01 PM, Babu Moger wrote: >> In x86, hardware uses CLOSID and an RMID to identify a control group and >> a monitoring group respectively. When a user creates a control or monitor >> group these details are not visible to the user. These details can help >> to debug the issues. > > "to debug the issues" -> "to debug issues"? Even so "issues" is vague, > perhaps just "These details can help debugging." Sure. > >> >> Add CLOSID(ctrl_hw_id) and RMID(mon_hw_id) to the control/monitor groups >> display in resctrl interface. Users can see these details when mounted > > "when mounted with" -> "when resctrl is mounted with"? Sure. > >> with "-o debug" option. > > Could you please add a snippet to explain the file naming choice? Just a > mention that this is done in support of other architectures that do not use > "CLOSID" and "RMID". Adding this. Other architectures do not use "CLOSID" and "RMID". Kept the names ctrl_hw_id and mon_hw_id to refer "CLOSID" and "RMID" respectively in an effort to keep the naming generic. > > Considering that, "x86/resctrl: Display hardware ids of resource groups" > may be a more appropriate subject. Sure. -- Thanks Babu Moger
