Hi Tony, On Wed, Jun 21, 2023 at 7:40 PM Tony Luck <tony.luck@xxxxxxxxx> wrote: > diff --git a/arch/x86/include/asm/resctrl.h b/arch/x86/include/asm/resctrl.h > index 255a78d9d906..f95e69bacc65 100644 > --- a/arch/x86/include/asm/resctrl.h > +++ b/arch/x86/include/asm/resctrl.h > @@ -35,6 +35,8 @@ DECLARE_STATIC_KEY_FALSE(rdt_enable_key); > DECLARE_STATIC_KEY_FALSE(rdt_alloc_enable_key); > DECLARE_STATIC_KEY_FALSE(rdt_mon_enable_key); > > +DECLARE_PER_CPU(int, rmid_offset); > + I assumed that declarations in this file were those needed by __resctrl_sched_in(). Now that rmid_offset is used when setting PQR_ASSOC, would this go somewhere else? Other than this and fixing the MSR update, the series looks fine to me. Reviewed-By: Peter Newman <peternewman@xxxxxxxxxx> Thanks! -Peter
