Re: [PATCH v9 10/42] x86/mm: Introduce _PAGE_SAVED

Re: [PATCH v9 10/42] x86/mm: Introduce _PAGE_SAVED_DIRTY

Date Prev

Date Next

Thread Prev

Thread Next

Date Index

Thread Index

To: "akpm@xxxxxxxxxxxxxxxxxxxx" <akpm@xxxxxxxxxxxxxxxxxxxx>, "tglx@xxxxxxxxxxxxx" <tglx@xxxxxxxxxxxxx>, "linux-arch@xxxxxxxxxxxxxxx" <linux-arch@xxxxxxxxxxxxxxx>, "kcc@xxxxxxxxxx" <kcc@xxxxxxxxxx>, "Lutomirski, Andy" <luto@xxxxxxxxxx>, "nadav.amit@xxxxxxxxx" <nadav.amit@xxxxxxxxx>, "kirill.shutemov@xxxxxxxxxxxxxxx" <kirill.shutemov@xxxxxxxxxxxxxxx>, "david@xxxxxxxxxx" <david@xxxxxxxxxx>, "Schimpe, Christina" <christina.schimpe@xxxxxxxxx>, "Torvalds, Linus" <torvalds@xxxxxxxxxxxxxxxxxxxx>, "peterz@xxxxxxxxxxxxx" <peterz@xxxxxxxxxxxxx>, "corbet@xxxxxxx" <corbet@xxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "jannh@xxxxxxxxxx" <jannh@xxxxxxxxxx>, "dethoma@xxxxxxxxxxxxx" <dethoma@xxxxxxxxxxxxx>, "broonie@xxxxxxxxxx" <broonie@xxxxxxxxxx>, "mike.kravetz@xxxxxxxxxx" <mike.kravetz@xxxxxxxxxx>, "pavel@xxxxxx" <pavel@xxxxxx>, "bp@xxxxxxxxx" <bp@xxxxxxxxx>, "rdunlap@xxxxxxxxxxxxx" <rdunlap@xxxxxxxxxxxxx>, "linux-api@xxxxxxxxxxxxxxx" <linux-api@xxxxxxxxxxxxxxx>, "john.allen@xxxxxxx" <john.allen@xxxxxxx>, "arnd@xxxxxxxx" <arnd@xxxxxxxx>, "jamorris@xxxxxxxxxxxxxxxxxxx" <jamorris@xxxxxxxxxxxxxxxxxxx>, "rppt@xxxxxxxxxx" <rppt@xxxxxxxxxx>, "bsingharora@xxxxxxxxx" <bsingharora@xxxxxxxxx>, "x86@xxxxxxxxxx" <x86@xxxxxxxxxx>, "oleg@xxxxxxxxxx" <oleg@xxxxxxxxxx>, "fweimer@xxxxxxxxxx" <fweimer@xxxxxxxxxx>, "keescook@xxxxxxxxxxxx" <keescook@xxxxxxxxxxxx>, "gorcunov@xxxxxxxxx" <gorcunov@xxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "hpa@xxxxxxxxx" <hpa@xxxxxxxxx>, "mingo@xxxxxxxxxx" <mingo@xxxxxxxxxx>, "szabolcs.nagy@xxxxxxx" <szabolcs.nagy@xxxxxxx>, "hjl.tools@xxxxxxxxx" <hjl.tools@xxxxxxxxx>, "debug@xxxxxxxxxxxx" <debug@xxxxxxxxxxxx>, "linux-mm@xxxxxxxxx" <linux-mm@xxxxxxxxx>, "Syromiatnikov, Eugene" <esyr@xxxxxxxxxx>, "Yang, Weijiang" <weijiang.yang@xxxxxxxxx>, "linux-doc@xxxxxxxxxxxxxxx" <linux-doc@xxxxxxxxxxxxxxx>, "dave.hansen@xxxxxxxxxxxxxxx" <dave.hansen@xxxxxxxxxxxxxxx>, "Eranian, Stephane" <eranian@xxxxxxxxxx>

Subject: Re: [PATCH v9 10/42] x86/mm: Introduce _PAGE_SAVED_DIRTY

From: "Edgecombe, Rick P" <rick.p.edgecombe@xxxxxxxxx>

Date: Tue, 13 Jun 2023 16:01:32 +0000

Accept-language: en-US

Cc: "Yu, Yu-cheng" <yu-cheng.yu@xxxxxxxxx>, "Xu, Pengfei" <pengfei.xu@xxxxxxxxx>

In-reply-to: <20230613001108.3040476-11-rick.p.edgecombe@intel.com>

References: <20230613001108.3040476-1-rick.p.edgecombe@intel.com> <20230613001108.3040476-11-rick.p.edgecombe@intel.com>

User-agent: Evolution 3.44.4-0ubuntu1

On Mon, 2023-06-12 at 17:10 -0700, Rick Edgecombe wrote:
> +#ifdef CONFIG_X86_64
> +#define _PAGE_SAVED_DIRTY      (_AT(pteval_t, 1) <<
> _PAGE_BIT_SAVED_DIRTY)
> +#else
> +#define _PAGE_SAVED_DIRTY      (_AT(pteval_t, 0))
> +#endif

Argh, the !CONFIG_X86_64 case here needs to be dropped now.