On 6/13/23 05:34, Sergei Shtepa wrote:
>
>
> On 6/13/23 03:51, Randy Dunlap wrote:
>>
>> On 6/9/23 04:58, Sergei Shtepa wrote:
>>> diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h
>>> index b7b56871029c..7904f157b245 100644
>>> --- a/include/uapi/linux/fs.h
>>> +++ b/include/uapi/linux/fs.h
>>> @@ -189,6 +189,9 @@ struct fsxattr {
>>> * A jump here: 130-136 are reserved for zoned block devices
>>> * (see uapi/linux/blkzoned.h)
>>> */
>>> +#define BLKFILTER_ATTACH _IOWR(0x12, 140, struct blkfilter_name)
>>> +#define BLKFILTER_DETACH _IOWR(0x12, 141, struct blkfilter_name)
>>> +#define BLKFILTER_CTL _IOWR(0x12, 142, struct blkfilter_ctl)
>>
>> Please update Documentation/userspace-api/ioctl/ioctl-number.rst
>> with the blkfilter ioctl number usage.
>
> It seems to me that there is no need to change anything in the table of
> numbers for 'blkfilter'. I think the existing record is enough:
>
> 0x10 20-2F arch/s390/include/uapi/asm/hypfs.h
> 0x12 all linux/fs.h
> linux/blkpg.h
Yes, OK.
> Maybe it would probably be correct to specify the file 'uapi/linux/fs.h'?
> And maybe we need to specify the request numbers for blksnap?
Yes.
> add ioctls numbers for blksnap
>
> Asked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Thanks.
> Signed-off-by: Sergei Shtepa <sergei.shtepa@xxxxxxxxx>
> ---
> Documentation/userspace-api/ioctl/ioctl-number.rst | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst b/Documentation/userspace-api/ioctl/ioctl-number.rst
> index 176e8fc3f31b..96af64988251 100644
> --- a/Documentation/userspace-api/ioctl/ioctl-number.rst
> +++ b/Documentation/userspace-api/ioctl/ioctl-number.rst
> @@ -202,6 +202,7 @@ Code Seq# Include File Comments
> 'V' C0 linux/ivtvfb.h conflict!
> 'V' C0 linux/ivtv.h conflict!
> 'V' C0 media/si4713.h conflict!
> +'V' 00-1F uapi/linux/blksnap.h conflict!
> 'W' 00-1F linux/watchdog.h conflict!
> 'W' 00-1F linux/wanrouter.h conflict! (pre 3.9)
> 'W' 00-3F sound/asound.h conflict!
--
~Randy
