Hi Danilo, kernel test robot noticed the following build warnings: [auto build test WARNING on 33a86170888b7e4aa0cea94ebb9c67180139cea9] url: https://github.com/intel-lab-lkp/linux/commits/Danilo-Krummrich/drm-execution-context-for-GEM-buffers-v4/20230607-063442 base: 33a86170888b7e4aa0cea94ebb9c67180139cea9 patch link: https://lore.kernel.org/r/20230606223130.6132-4-dakr%40redhat.com patch subject: [PATCH drm-next v4 03/14] drm: manager to keep track of GPUs VA mappings config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20230607/202306071203.Gn8jrmLz-lkp@xxxxxxxxx/config) compiler: alpha-linux-gcc (GCC) 12.3.0 reproduce (this is a W=1 build): mkdir -p ~/bin wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 33a86170888b7e4aa0cea94ebb9c67180139cea9 b4 shazam https://lore.kernel.org/r/20230606223130.6132-4-dakr@xxxxxxxxxx # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=alpha olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash drivers/gpu/drm/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202306071203.Gn8jrmLz-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): drivers/gpu/drm/drm_gpuva_mgr.c: In function '__drm_gpuva_sm_map': >> drivers/gpu/drm/drm_gpuva_mgr.c:1032:32: warning: variable 'prev' set but not used [-Wunused-but-set-variable] 1032 | struct drm_gpuva *va, *prev = NULL; | ^~~~ vim +/prev +1032 drivers/gpu/drm/drm_gpuva_mgr.c 1024 1025 static int 1026 __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr, 1027 const struct drm_gpuva_fn_ops *ops, void *priv, 1028 u64 req_addr, u64 req_range, 1029 struct drm_gem_object *req_obj, u64 req_offset) 1030 { 1031 DRM_GPUVA_ITER(it, mgr, req_addr); > 1032 struct drm_gpuva *va, *prev = NULL; 1033 u64 req_end = req_addr + req_range; 1034 int ret; 1035 1036 if (unlikely(!drm_gpuva_in_mm_range(mgr, req_addr, req_range))) 1037 return -EINVAL; 1038 1039 if (unlikely(drm_gpuva_in_kernel_node(mgr, req_addr, req_range))) 1040 return -EINVAL; 1041 1042 drm_gpuva_iter_for_each_range(va, it, req_end) { 1043 struct drm_gem_object *obj = va->gem.obj; 1044 u64 offset = va->gem.offset; 1045 u64 addr = va->va.addr; 1046 u64 range = va->va.range; 1047 u64 end = addr + range; 1048 bool merge = !!va->gem.obj; 1049 1050 if (addr == req_addr) { 1051 merge &= obj == req_obj && 1052 offset == req_offset; 1053 1054 if (end == req_end) { 1055 ret = op_unmap_cb(ops, &it, priv, va, merge); 1056 if (ret) 1057 return ret; 1058 break; 1059 } 1060 1061 if (end < req_end) { 1062 ret = op_unmap_cb(ops, &it, priv, va, merge); 1063 if (ret) 1064 return ret; 1065 goto next; 1066 } 1067 1068 if (end > req_end) { 1069 struct drm_gpuva_op_map n = { 1070 .va.addr = req_end, 1071 .va.range = range - req_range, 1072 .gem.obj = obj, 1073 .gem.offset = offset + req_range, 1074 }; 1075 struct drm_gpuva_op_unmap u = { 1076 .va = va, 1077 .keep = merge, 1078 }; 1079 1080 ret = op_remap_cb(ops, &it, priv, NULL, &n, &u); 1081 if (ret) 1082 return ret; 1083 break; 1084 } 1085 } else if (addr < req_addr) { 1086 u64 ls_range = req_addr - addr; 1087 struct drm_gpuva_op_map p = { 1088 .va.addr = addr, 1089 .va.range = ls_range, 1090 .gem.obj = obj, 1091 .gem.offset = offset, 1092 }; 1093 struct drm_gpuva_op_unmap u = { .va = va }; 1094 1095 merge &= obj == req_obj && 1096 offset + ls_range == req_offset; 1097 u.keep = merge; 1098 1099 if (end == req_end) { 1100 ret = op_remap_cb(ops, &it, priv, &p, NULL, &u); 1101 if (ret) 1102 return ret; 1103 break; 1104 } 1105 1106 if (end < req_end) { 1107 ret = op_remap_cb(ops, &it, priv, &p, NULL, &u); 1108 if (ret) 1109 return ret; 1110 goto next; 1111 } 1112 1113 if (end > req_end) { 1114 struct drm_gpuva_op_map n = { 1115 .va.addr = req_end, 1116 .va.range = end - req_end, 1117 .gem.obj = obj, 1118 .gem.offset = offset + ls_range + 1119 req_range, 1120 }; 1121 1122 ret = op_remap_cb(ops, &it, priv, &p, &n, &u); 1123 if (ret) 1124 return ret; 1125 break; 1126 } 1127 } else if (addr > req_addr) { 1128 merge &= obj == req_obj && 1129 offset == req_offset + 1130 (addr - req_addr); 1131 1132 if (end == req_end) { 1133 ret = op_unmap_cb(ops, &it, priv, va, merge); 1134 if (ret) 1135 return ret; 1136 break; 1137 } 1138 1139 if (end < req_end) { 1140 ret = op_unmap_cb(ops, &it, priv, va, merge); 1141 if (ret) 1142 return ret; 1143 goto next; 1144 } 1145 1146 if (end > req_end) { 1147 struct drm_gpuva_op_map n = { 1148 .va.addr = req_end, 1149 .va.range = end - req_end, 1150 .gem.obj = obj, 1151 .gem.offset = offset + req_end - addr, 1152 }; 1153 struct drm_gpuva_op_unmap u = { 1154 .va = va, 1155 .keep = merge, 1156 }; 1157 1158 ret = op_remap_cb(ops, &it, priv, NULL, &n, &u); 1159 if (ret) 1160 return ret; 1161 break; 1162 } 1163 } 1164 next: 1165 prev = va; 1166 } 1167 1168 return op_map_cb(ops, priv, 1169 req_addr, req_range, 1170 req_obj, req_offset); 1171 } 1172 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
