On Wed, 31 May 2023 18:46:23 +0800 Junhao He <hejunhao3@xxxxxxxxxx> wrote: > Compared to the original PA device, H60PA offers higher bandwidth. > The H60PA is a new device and we use HID to differentiate them. > > The events supported by PAv3 and PAv2 are different. They use the > same HID. The PMU version register is used in the driver to > distinguish different versions. > > For each H60PA PMU, except for the overflow interrupt register, other > functions of the H60PA PMU are the same as the original PA PMU module. > It has 8-programable counters and each counter is free-running. > Interrupt is supported to handle counter (64-bits) overflow. > > Signed-off-by: Junhao He <hejunhao3@xxxxxxxxxx> Hi, I would have slightly preferred to see the refactoring done as a first patch and then the new device supported added in a second, but as that second patch would only be a few lines I don't mind that much. The result looks fine to me. Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
