Hi Babu, On 5/5/2023 2:45 PM, Moger, Babu wrote: > On 5/4/2023 2:04 PM, Reinette Chatre wrote: Thank you for trimming the header in replies. >> On 4/17/2023 4:34 PM, Babu Moger wrote: >>> When a user creates a control or monitor group, the CLOSID or RMID >>> are not visible to the user. It can help to debug the issues in some >>> cases. There are only available with "-o debug" option. >> Please see: Documentation/process/maintainer-tip.rst >> >> "It's also useful to structure the changelog into several paragraphs and not >> lump everything together into a single one. A good structure is to explain >> the context, the problem and the solution in separate paragraphs and this >> order." > ok Sure. >>> Add CLOSID(ctrl_hw_id) and RMID(mon_hw_id) to the control/monitor groups >> Please highlight that CLOSID and RMID are x86 concepts. > ok Sure. >> >>> display in resctrl interface. >>> $cat /sys/fs/resctrl/clos1/clos_hw_id >>> 1 >> This example does not match what the patch does (clos_hw_id -> ctrl_hw_id). > My bad. Will fix it. >> I also think this change would be more palatable (to non x86 audience) if >> the example resource group has a generic (non-x86 concept) name. > > ok. In this example the clos1 name sounds x86 specific. I can change it to ctrl_grp1. Hope this is what you meant. Yes, that is what I meant. ctrl_grp1 sounds good. Thank you Reinette
