Hi Babu, On 5/5/2023 8:43 AM, Moger, Babu wrote: > [AMD Official Use Only - General] > > Hi Reinette, > >> -----Original Message----- >> From: Reinette Chatre <reinette.chatre@xxxxxxxxx> >> Sent: Thursday, May 4, 2023 1:54 PM >> To: Moger, Babu <Babu.Moger@xxxxxxx>; corbet@xxxxxxx; >> tglx@xxxxxxxxxxxxx; mingo@xxxxxxxxxx; bp@xxxxxxxxx >> Cc: fenghua.yu@xxxxxxxxx; dave.hansen@xxxxxxxxxxxxxxx; x86@xxxxxxxxxx; >> hpa@xxxxxxxxx; paulmck@xxxxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx; >> quic_neeraju@xxxxxxxxxxx; rdunlap@xxxxxxxxxxxxx; >> damien.lemoal@xxxxxxxxxxxxxxxxxx; songmuchun@xxxxxxxxxxxxx; >> peterz@xxxxxxxxxxxxx; jpoimboe@xxxxxxxxxx; pbonzini@xxxxxxxxxx; >> chang.seok.bae@xxxxxxxxx; pawan.kumar.gupta@xxxxxxxxxxxxxxx; >> jmattson@xxxxxxxxxx; daniel.sneddon@xxxxxxxxxxxxxxx; Das1, Sandipan >> <Sandipan.Das@xxxxxxx>; tony.luck@xxxxxxxxx; james.morse@xxxxxxx; >> linux-doc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; >> bagasdotme@xxxxxxxxx; eranian@xxxxxxxxxx; christophe.leroy@xxxxxxxxxx; >> jarkko@xxxxxxxxxx; adrian.hunter@xxxxxxxxx; quic_jiles@xxxxxxxxxxx; >> peternewman@xxxxxxxxxx >> Subject: Re: [PATCH v4 0/7] x86/resctrl: Miscellaneous resctrl features >> ... >>> Tried to address Reinette's comment on patch 7. But due to current code >> design >>> I could not do it exact way. But changed it little bit to make it easy debug >>> file additions in the future. >> >> Could you please elaborate? It actually looks like you may be headed there next >> according to: >> https://lore.kernel.org/lkml/933d8ae2-d8b7-7436-5918- >> f639405c9ecb@xxxxxxx/ > > Sorry, I was talking about this comment. > https://lore.kernel.org/lkml/fef12c9e-7d6f-bcd4-f92e-e776eb9e673b@xxxxxxxxx/ > > I tried to address it here. > https://lore.kernel.org/lkml/168177451010.1758847.568218491528297451.stgit@bmoger-ubuntu/ > > This may not be the exact way you mentioned. Reason is, adding the > flags before rdtgroup_add_files cannot be done. It does not update > the resctrl root filesystem. These files have to added by calling > rdtgroup_add_file and kernfs_activate in rdt_enable_ctx. I think what you are referring to is files not appearing in the default resource group? From what I can tell the files should appear when new resource groups are created. Could the default resource group's files not also be added on resctrl mount (moved from rdtgroup_setup_root() to rdt_get_tree())? I do not see why the files belonging to the default group are required to be added before resctrl mount and with the move the resctrl_debug flag can continue to be set in rdt_enable_ctx() and available to rdtgroup_add_files() when adding the default resource group's files. To me this sounds simpler since there is no duplicate file add/remove code, and the debug files are just another file type. Reinette
