On 4/24/23 14:20, Armin Wolf wrote: > Am 22.04.23 um 04:54 schrieb Randy Dunlap: > >> Hi, >> >> On 4/20/23 16:32, Armin Wolf wrote: >>> Add kernel doc comments useful for documenting the functions/structs >>> used to interact with the WMI driver core. >>> >>> Signed-off-by: Armin Wolf <W_Armin@xxxxxx> >>> --- >>> drivers/platform/x86/wmi.c | 51 +++++++++++++++++++++++++++++++------- >>> include/linux/wmi.h | 41 +++++++++++++++++++++++++++--- >>> 2 files changed, 80 insertions(+), 12 deletions(-) >>> >>> +/** >>> + * struct wmi_device - WMI device structure >>> + * @dev: Device associated with this WMI device >>> + * @setable: True for devices implementing the Set Control Method >> private: fields are not normally documented in kernel-doc. > > Hi, > > since @setable is only used internally by the WMI driver core, i thought it might > be beneficial to exclude it from the normal driver interface documentation and only > use it for subsystem-internal documentation. OK then. :) -- ~Randy
