On Wed, Apr 19, 2023 at 02:53:45PM +0200, Krzysztof Kozlowski wrote: > On 17/04/2023 17:17, Christian Marangi wrote: > > Add Switch LED for each port for MikroTik RB3011UiAS-RM. > > > > MikroTik RB3011UiAS-RM is a 10 port device with 2 qca8337 switch chips > > connected. > > > > It was discovered that in the hardware design all 3 Switch LED trace of > > the related port is connected to the same LED. This was discovered by > > setting to 'always on' the related led in the switch regs and noticing > > that all 3 LED for the specific port (for example for port 1) cause the > > connected LED for port 1 to turn on. As an extra test we tried enabling > > 2 different LED for the port resulting in the LED turned off only if > > every led in the reg was off. > > > > Aside from this funny and strange hardware implementation, the device > > itself have one green LED for each port, resulting in 10 green LED one > > for each of the 10 supported port. > > > > Cc: Jonathan McDowell <noodles@xxxxxxxx> > > Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx> > > --- > > arch/arm/boot/dts/qcom-ipq8064-rb3011.dts | 120 ++++++++++++++++++++++ > > Please do not send the DTS patches to the net-next, but to the Qualcomm > SoC maintainers. The DTS must not be mixed with driver code. > Hi, sorry for the mess, it was asked to give an user of the LED feature for qca8k so I was a bit confused on where to include it and at the end I decided to put it in this series. What was the correct way? 2 different series and reference the DT one in the net-next? (or not targetting net-next at all?) -- Ansuel
