Hi there, Version 9 review for the sysfs-class-firmware-attributes document was submitted and I look forward to getting your comments. I understand you have other things happening, but as soon as the document is finalized, I can move to submit the rest of the files. While the document review is ongoing, I proceeded to address all comments made by Thomas, Hans, Bagas, and Mark regarding both documentation and source code changes. The code compiles with W=1 flag without any issues and the refactoring proposed by Thomas was incorporated. Testing on multiple platforms continues to validate the driver proper operation between reviews. Regards, Jorge On Thu, Apr 6, 2023 at 9:08 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Hi All, > > FWIW I have been reading along with both the v6 and > this v7 posting. > > Thomas, Mark, thank you for your review / feedback > on this series. > > On 4/4/23 15:37, Jorge Lopez wrote: > > Hi Bagas, > > > >> > >> Where is the rest of patches if this is a series? Had they been merged? > >> > > > > There is only one change as requested by Thomas Weißschuh > > > >> Feel free to ONLY submit the patch with the documentation for the next > >> revision. Then we can nail down the interface and initial functionality > >> and you don't always have to adapt the code to the changing interface. > > > > Perhaps, I misunderstood Thomas request. I will address a few other > > comments and will submit all files again. > > I think that Thomas' suggestion to first focus on getting > the userspace API right and then implement the agreed > upon API is a good idea. > > So for the next version just post only the documentation > patch again please. > > Note it is not the intention to merge just the documentation > patch without merging the code first. > > The idea is to first nail the API down and then modify > the code once to implement the agreed upon API. > > Then once the API has been agreed upon post newer > versions which also include the code again. > > And then once people are also happy with the code > we can merge both the code + documentation in one go. > > Regards, > > Hans > > > > > > > > > > > Regards, > > > > Jorge > > >
