Re: [PATCH v2] ASoC: Add PCM1681 codec driver.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 01, 2013 at 11:14:58AM +0200, Marek Belisko wrote:
> PCM1681 can be controlled via I2C, SPI or in bootstrap mode (no control mode). This code add
> support only for I2C mode.

Applied, thanks.  One thing:

> +	if (val != -1) {
> +		regmap_update_bits(priv->regmap, PCM1681_DEEMPH_CONTROL,
> +					PCM1681_DEEMPH_RATE_MASK, val);
> +		enable = 1;
> +	} else
> +		enable = 0;

The style is to have braces on both sides of the else if it's one one.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux