On Thu, Mar 16, 2023 at 09:23:28AM +0100, Krzysztof Kozlowski wrote: > On 16/03/2023 09:20, Bagas Sanjaya wrote: > > An interpretation of submitting-patches.rst regarding Fixes: tag > > interprets that the tag can be attributed to all kinds of issues > > (including coding style ones). However, from the discussion on Outreachy > > mailing list [1], Greg noted that the tag should not be meant for > > patches that fix coding style issues. > > > > Clarify the position on the doc. > > > > Link: https://lore.kernel.org/outreachy/ZBFPnZbvdI46Ah6r@xxxxxxxxx/ [1] > > Signed-off-by: Bagas Sanjaya <bagasdotme@xxxxxxxxx> > > --- > > Documentation/process/submitting-patches.rst | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst > > index 69ce64e03c70f8..564418e42ffc01 100644 > > --- a/Documentation/process/submitting-patches.rst > > +++ b/Documentation/process/submitting-patches.rst > > @@ -568,6 +568,9 @@ process nor the requirement to Cc: stable@xxxxxxxxxxxxxxx on all stable > > patch candidates. For more information, please read > > Documentation/process/stable-kernel-rules.rst. > > > > +Note: Fixes: tag is appropriate only for real issues (e.g. reported bugs > > +or compiler warnings). Coding style fixes should not bear this tag. > > I think it is pretty clear already. The doc says: > "If your patch fixes a bug in a specific commit," > > and you are now repeating this. > > Coding style is not a bug, but that's obvious. I agree, let's not make this file even longer than it is if at all possible. thanks, greg k-h
