On Tue, Mar 7, 2023 at 11:25 AM Conor Dooley <conor.dooley@xxxxxxxxxxxxx> wrote:
>
> Despite removing 32-bit support, I kept the structure of the if
> statement, despite early return being stylistically preferred, for
> alignment with the Rust-for-Linux tree. I'm happy to respin to sort that
> out of desired.
This is a case of 2 "equal" sides to the branch (though at the moment
an error), so it sounds good, and it will mean a smaller diff later.
> + panic!("32-bit RISC-V is an unsupported architecture")
Nit: if there is a v2, please add a semicolon to be consistent with
the others in the file (not sure which style we will go for, it looks
like `rustfmt` accepts both ways).
Cheers,
Miguel
