Re: [PATCH 08/21] x86, acpi: Also initialize signature and length when parsing root table.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/24/2013 03:45 AM, Tejun Heo wrote:
On Fri, Jul 19, 2013 at 03:59:21PM +0800, Tang Chen wrote:
@@ -514,6 +514,7 @@ acpi_tb_install_table(acpi_physical_address address,
  	 * fully mapped later (in verify table). In any case, we must
  	 * unmap the header that was mapped above.
  	 */
+	table_desc =&acpi_gbl_root_table_list.tables[table_index];
  	final_table = acpi_tb_table_override(table, table_desc);
  	if (!final_table) {
  		final_table = table;	/* There was no override */

Is this chunk correct?  Why is @table_desc being assigned twice in
this function?

Oh, my mistake. The second assignment is redundant. Only the first one is
useful. Will remove the redundant assignment in this patch.

Thanks.


+	/*
+	 * Also initialize the table entries here, so that later we can use them
+	 * to find SRAT at very eraly time to reserve hotpluggable memory.
                                 ^ typo
Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux