On 2/23/2023 4:09 PM, Alex Elder wrote:
On 2/14/23 3:12 PM, Elliot Berman wrote:
+
+void gh_hypercall_hyp_identify(struct gh_hypercall_hyp_identify_resp
*hyp_identity);
Since this is a user space API, you *could* consider having
this function return an int. Just in case there's a future
reason that a failure could occur, or that you want to
supply some other information. If this truly doesn't make
sense, it's fine as-is...
I'm not sure what was meant by user space API. However, hypervisor API
doesn't provision a return value. r0 is usually the return value for
most other Gunyah hypercalls except for this one -- instead, it's the
api_info field.
The other kind of error we could get is at hypercall "transport" layer,
but the hvc instruction doesn't fail and if we ever change the hypercall
transport, I'm sure there will be a lot of other changes to consider as
well.
Thanks,
Elliot
