On Wed, Mar 01, 2023 at 09:08:03AM -0700, Jeffrey Hugo wrote: > > This looks a bit suspicious. Are you sure you can modify > > sg->dma_address and still use it as valid value ? > > A single entry in the sg table is a contiguous mapping of memory. If it > wasn't contiguous, it would have to be broken up into multiple entries. In > the simple case, a driver is going to take the dma_address/len pair and hand > that directly to the device. Then the device is going to access every > address in that range. > > If the device can access every address from dma_address to dma_address + > len, why can't it access a subset of that? Required address alignment can be broken. Not sure if only that. > > > Are you suggesting renaming > > > this function? I guess I'm not quite understanding your comment here. Can > > > you elaborate? > > > > Renaming would be nice. I was thinking by simplifying it, not sure > > now if that's easy achievable, though. > > Ok. I'll think on this. Maybe this function could be removed ? And create sg lists that hardware can handle without any modification. Just idea to consider, not any requirement. Regards Stanislaw
