On Wed, Jul 24, 2013 at 10:42:28AM +0100, Mark Brown wrote: > On Wed, Jul 24, 2013 at 10:30:41AM +0200, Steffen Trumtrar wrote: > > On Sun, Jul 21, 2013 at 05:17:27PM +0800, Robin Gong wrote: > > > > > static struct regulator_ops pfuze100_fixed_regulator_ops = { > > .list_voltage = regulator_list_voltage_linear, > > + .set_voltage_sel = regulator_set_voltage_sel_regmap, > > }; > > This doesn't make much sense, you're adding a set voltage operation to a > fixed voltage regulator... Hm, okay, sounds reasonable. But if I don't, VREFDDR isn't registered because _regulator_do_set_voltage returns with -EINVAL. So, I probably just fixed a symptom and not the cause. Thanks, Steffen -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html