Re: [PATCH] media: Fix building pdfdocs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 27/02/2023 14:06, Akira Yokosawa wrote:
Hi Mauro,

On Sun, 26 Feb 2023 11:47:44 +0100, Mauro Carvalho Chehab wrote:
Em Sun, 26 Feb 2023 08:39:32 +0900
Akira Yokosawa <akiyks@xxxxxxxxx> escreveu:

[+CC: Jon, linux-doc]

On Wed,  8 Feb 2023 10:29:16 +0200, Tomi Valkeinen wrote:
Commit 8d0e3fc61abd ("media: Add 2-10-10-10 RGB formats") added
documatation for a few new RGB formats. For some reason these break the
pdfdocs build, even if the same style seems to work elsewhere in the
file.

Remove the trailing empty dash lines, which seems to fix the issue.

Fixes: 8d0e3fc61abd ("media: Add 2-10-10-10 RGB formats")
Reported-by: Akira Yokosawa <akiyks@xxxxxxxxx>
Link: https://lore.kernel.org/r/12250823-8445-5854-dfb8-b92c0ff0851e@xxxxxxxxx/

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>
---

Note: the offending patch was merged via drm tree, so we may want to
apply the fix to the drm tree also.

So, the offending commit is now in mainline without this fix...
I believe this build regression -- a real build error of "make pdfdocs"
-- should be fixed ASAP.

Tomi, Laurent has suggested a typo fix in the Changelog.
Can you respin ?

Or, Laurent, can you do the fix on your own?

Hopefully, the fix can make v6.3-rc1.

Better to wait for media PR to be handled. There were some changes at
the documentation that affected the patch. I guess the bug is gone.

You mean the PR at https://lore.kernel.org/lkml/20230226114551.68480d44@xxxxxxxx/ ?
Unfortunately, it has had no effect on this issue.

If not, we'll need to rebase the patch.

There was no change in Documentation/userspace-api/media/v4l/pixfmt-rgb.rst,
so rebase is not needed.

Should this bug survive v6.3-rc1, I guess this fix could go through
media or doc tree.

This patch applies fine on top of current Linus' master.

As this is a media patch, and the offending commit is now in upstream, maybe it's better to get this fix in via linux-media rather than linux-drm.

Mauro, can you pick this up?

 Tomi




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux