Hi Conor, On Fri, Feb 24, 2023 at 2:37 PM Conor Dooley <conor.dooley@xxxxxxxxxxxxx> wrote: > > This is a somewhat blind (and maybe foolish) attempt at enabling Rust > for RISC-V. I've tested this on Icicle, and the modules seem to work. > I'd like to play around with Rust on RISC-V, but I'm not interested in > using downstream kernels, so figured I should try and see what's > missing... > I've tagged this as RFC in case I've missed some "WAaaaa you can't do > this" somewhere :) Thanks for sending this and taking the lead on RISC-V -- I appreciate you put me as the author, but in this case, it was actually Gary that started the RISC-V port [1], and then I sent three PRs on top later on. When submitting something on behalf of somebody else, I suggest being very careful and ideally contacting the authors beforehand. In particular, if there has been any modification (including to the commit message), then a note should be added explaining so. Therefore, please double-check everybody that contributed to the lines you are sending (e.g. via `git-blame`) and add them as `Co-developed-by`. Also, please add a note of what you changed/wrote e.g. square brackets, and `Link` tags to the original PRs/discussions. See, for instance, what Jamie did at [2] for arm64 or Lina at [3]. [1] https://github.com/Rust-for-Linux/linux/pull/225 [2] https://lore.kernel.org/rust-for-linux/20230125163739.3798252-2-Jamie.Cunliffe@xxxxxxx/ [3] https://lore.kernel.org/rust-for-linux/20230224-rust-vec-v1-4-733b5b5a57c5@xxxxxxxxxxxxx/ Cheers, Miguel