On Mon, 20 Feb 2023 13:29:31 +0200 Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Mon, Feb 20, 2023 at 06:09:32PM +1100, Orlando Chamberlain wrote: > > On Sun, 19 Feb 2023 16:09:26 +0200 > > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > > On Sat, Feb 18, 2023 at 11:08 AM Orlando Chamberlain > > > <orlandoch.dev@xxxxxxxxx> wrote: > > ... > > > > > + help > > > > + Say Y here if you want support for the keyboard > > > > backlight on Macs with > > > > + the magic keyboard (MacBookPro16,x and MacBookAir9,1). > > > > Note that this > > > > + driver is not for external magic keyboards. > > > > + > > > > + To compile this driver as a module, choose M here: the > > > > + module will be called hid-apple-magic-backlight. > > > > > > Is it my email client or is the indentation of the help text > > > incorrect? > > > > > > Hint: the text of the help should be <TAB><SPACE><SPACE> indented. > > > > > > I believe checkpatch.pl at least in --strict mode should complain > > > about this. > > > > Looking at the hid Kconfig, it seems like some have it as you've > > described, and some just have tab (and a few have just tab for the > > first line, and tab space space for the rest of the lines). > > Okay, I have checked in the other MUA I'm using for patch reviews and > indeed your Kconfig indentation is broken. > > > checkpatch.pl --strict didn't complain about the indentation so > > hopefully it's alright as is. > > No, it's not. Must be fixed. > > https://www.kernel.org/doc/html/latest/process/coding-style.html#kconfig-configuration-files > No worries, I'll fix that in v5.
