Re: [PATCH 01/21] acpi: Print Hot-Pluggable Field in SRAT.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2013-07-23 at 14:48 -0400, Tejun Heo wrote:
> On Fri, Jul 19, 2013 at 03:59:14PM +0800, Tang Chen wrote:
> > The Hot-Pluggable field in SRAT suggests if the memory could be
> > hotplugged while the system is running. Print it as well when
> > parsing SRAT will help users to know which memory is hotpluggable.
[]
> a nit below
> 
> > +	pr_info("SRAT: Node %u PXM %u [mem %#010Lx-%#010Lx] %s\n",
> > +		node, pxm,
> > +		(unsigned long long) start, (unsigned long long) end - 1,
> > +		hotpluggable ? "Hot Pluggable" : "");
> 
> The following would be more conventional.
> 
>   "...10Lx]%s\n", ..., hotpluggable ? " Hot Pluggable" : ""
> 
> Also, isn't "Hot Pluggable" a bit too verbose?  "hotplug" should be
> fine, I think.

It's also a tiny nit better to use:

	pr_info("SRAT: Node %u PXM %u [mem %#010Lx-%#010Lx]%s\n",
		node, pxm,
		(unsigned long long) start, (unsigned long long) end - 1,
		hotpluggable ? " Hot Pluggable" : "");

(or " hotplug")

so there's no space before newline.

--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux