Re: [PATCH] sfc: fix builds without CONFIG_RTC_LIB

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



BTW, I did not send the net-next tag what I'm not sure if it is required 
(I would say so).

Should I add it?

Thanks

On 2/17/23 15:20, Lucero Palau, Alejandro wrote:
> On 2/17/23 14:47, Alexander Lobakin wrote:
>> From: Lucero Palau, Alejandro <alejandro.lucero-palau@xxxxxxx>
>> Date: Fri, 17 Feb 2023 10:22:36 +0000
>>
>>> From: Alejandro Lucero <alejandro.lucero-palau@xxxxxxx>
>>>
>>> Adding an embarrasing missing semicolon precluding kernel building
>> :D
>>
>> 'Embarrassing' tho, with two 's'. And I guess "embarrassingly missed",
>> since a semicolon itself can't be "embarrassing" I believe? :D
> This is going worse ... :D
>
> I'll change it.
>
>> + "add", not "adding"
>> + "precluding"? You mean "breaking"?
> Preclude: "prevent from happening; make impossible."
>
> But I can use breaking instead.
>
> Thanks!
>
>>> in ia64 configs.
>>>
>>> Reported-by: kernel test robot <lkp@xxxxxxxxx>
>>> Link: https://lore.kernel.org/oe-kbuild-all/202302170047.EjCPizu3-lkp@xxxxxxxxx/
>>> Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100")
>>> Signed-off-by: Alejandro Lucero <alejandro.lucero-palau@xxxxxxx>
>>> ---
>>>    drivers/net/ethernet/sfc/efx_devlink.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c
>>> index d2eb6712ba35..3eb355fd4282 100644
>>> --- a/drivers/net/ethernet/sfc/efx_devlink.c
>>> +++ b/drivers/net/ethernet/sfc/efx_devlink.c
>>> @@ -323,7 +323,7 @@ static void efx_devlink_info_running_v2(struct efx_nic *efx,
>>>    				    GET_VERSION_V2_OUT_SUCFW_BUILD_DATE);
>>>    		rtc_time64_to_tm(tstamp, &build_date);
>>>    #else
>>> -		memset(&build_date, 0, sizeof(build_date)
>>> +		memset(&build_date, 0, sizeof(build_date);
>>>    #endif
>>>    		build_id = MCDI_DWORD(outbuf, GET_VERSION_V2_OUT_SUCFW_CHIP_ID);
>>>    
>> Thanks,
>> Olek




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux