On Mon, Feb 13, 2023 at 06:34:22PM +0000, alejandro.lucero-palau@xxxxxxx wrote:
> From: Alejandro Lucero <alejandro.lucero-palau@xxxxxxx>
>
> Add devlink info support for ef100. The information reported is obtained
> through the MCDI interface with the specific meaning defined in new
> documentation file.
>
> Signed-off-by: Alejandro Lucero <alejandro.lucero-palau@xxxxxxx>
> Reviewed-by: Jiri Pirko <jiri@xxxxxxxxxx>
> ---
> Documentation/networking/devlink/index.rst | 1 +
> Documentation/networking/devlink/sfc.rst | 57 +++
> MAINTAINERS | 1 +
> drivers/net/ethernet/sfc/efx_devlink.c | 459 +++++++++++++++++++++
> drivers/net/ethernet/sfc/efx_devlink.h | 17 +
> drivers/net/ethernet/sfc/mcdi.c | 72 ++++
> drivers/net/ethernet/sfc/mcdi.h | 3 +
> 7 files changed, 610 insertions(+)
> create mode 100644 Documentation/networking/devlink/sfc.rst
<...>
> +static void efx_devlink_info_running_v2(struct efx_nic *efx,
> + struct devlink_info_req *req,
> + unsigned int flags, efx_dword_t *outbuf)
> +{
> + char buf[EFX_MAX_VERSION_INFO_LEN];
> + union {
> + const __le32 *dwords;
> + const __le16 *words;
> + const char *str;
> + } ver;
> + struct rtc_time build_date;
> + unsigned int build_id;
> + size_t offset;
> +#ifdef CONFIG_RTC_LIB
> + u64 tstamp;
> +#endif
If you are going to resubmit the series.
Documentation/process/coding-style.rst
1140 21) Conditional Compilation
1141 ---------------------------
....
1156 If you have a function or variable which may potentially go unused in a
1157 particular configuration, and the compiler would warn about its definition
1158 going unused, mark the definition as __maybe_unused rather than wrapping it in
1159 a preprocessor conditional. (However, if a function or variable *always* goes
1160 unused, delete it.)
Thanks
