Re: [PATCH] Documentation: riscv: fix insufficient list item indent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 29 Jan 2023 19:05:53 PST (-0800), bagasdotme@xxxxxxxxx wrote:
On Sun, Jan 29, 2023 at 11:57:01PM +0000, Conor Dooley wrote:
From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

When adding the ISA string ordering rules, I didn't sufficiently indent
one of the list items.

Reported-by: kernel test robot <lkp@xxxxxxxxx>
Fixes: f07b2b3f9d47 ("Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo")
Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Seems like you forget to add link to the report:

Link: https://lore.kernel.org/linux-doc/202301300743.bp7Dpazv-lkp@xxxxxxxxx/

Is that the normal way to do it? I've only been adding the Reported-by like the bot suggests, but I guess it's kind of nice information to have the bug report as well. From looking at git history it's kind of a mix.

Maybe the bot should suggest this in the bug report, right next to the other
tag?

---
 Documentation/riscv/uabi.rst | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/riscv/uabi.rst b/Documentation/riscv/uabi.rst
index 2ebec4c52230..8960fac42c40 100644
--- a/Documentation/riscv/uabi.rst
+++ b/Documentation/riscv/uabi.rst
@@ -21,10 +21,10 @@ so for our purposes the following rules apply:
    single-letter extensions and before any higher-privileged extensions.
#. For additional standard extensions, the first letter following the 'Z'
-  conventionally indicates the most closely related alphabetical
-  extension category. If multiple 'Z' extensions are named, they will be ordered
-  first by category, in canonical order, as listed above, then alphabetically
-  within a category.
+   conventionally indicates the most closely related alphabetical
+   extension category. If multiple 'Z' extensions are named, they will be
+   ordered first by category, in canonical order, as listed above, then
+   alphabetically within a category.
#. Standard supervisor-level extensions (starting with 'S') will be listed
    after standard unprivileged extensions.  If multiple supervisor-level

The warning is fixed, thanks!

Reviewed-by: Bagas Sanjaya <bagasdotme@xxxxxxxxx>

--
An old man doll... just what I always wanted! - Clara



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux