On 02/02/2023 11:14, alejandro.lucero-palau@xxxxxxx wrote:
> From: Alejandro Lucero <alejandro.lucero-palau@xxxxxxx>
>
> MAE ports (mports) are the ports on the EF100 embedded switch such
> as networking PCIe functions, the physical port, and potentially
> others.
>
> Signed-off-by: Alejandro Lucero <alejandro.lucero-palau@xxxxxxx>
...
> +struct mae_mport_desc {
> + u32 mport_id;
> + u32 flags;
> + u32 caller_flags; /* enum mae_mport_desc_caller_flags */
> + u32 mport_type; /* MAE_MPORT_DESC_MPORT_TYPE_* */
> + union {
> + u32 port_idx; /* for mport_type == NET_PORT */
> + u32 alias_mport_id; /* for mport_type == ALIAS */
> + struct { /* for mport_type == VNIC */
> + u32 vnic_client_type; /* MAE_MPORT_DESC_VNIC_CLIENT_TYPE_* */
> + u32 interface_idx;
> + u16 pf_idx;
> + u16 vf_idx;
> + };
> + };
> + struct rhash_head linkage;
> + struct efx_rep *efv;
Looks like this isn't used or populated anywhere, so probably
shouldn't be added yet.
Apart from that, LGTM.
