Hi Gregory, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on tip/core/entry v6.2-rc5 next-20230127] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Gregory-Price/ptrace-syscall_user_dispatch-checkpoint-restore-support-for-SUD/20230128-145101 patch link: https://lore.kernel.org/r/20230126190645.18341-2-gregory.price%40memverge.com patch subject: [PATCH v7 1/1] ptrace,syscall_user_dispatch: checkpoint/restore support for SUD config: x86_64-rhel-8.3-syz (https://download.01.org/0day-ci/archive/20230128/202301281932.AtpbMlh9-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/bc68df21f98617e74a8c5368a901041f89bdb17f git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Gregory-Price/ptrace-syscall_user_dispatch-checkpoint-restore-support-for-SUD/20230128-145101 git checkout bc68df21f98617e74a8c5368a901041f89bdb17f # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 olddefconfig make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash kernel/entry/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): kernel/entry/syscall_user_dispatch.c: In function 'syscall_user_dispatch_get_config': kernel/entry/syscall_user_dispatch.c:114:45: error: storage size of 'config' isn't known 114 | struct syscall_user_dispatch_config config; | ^~~~~~ kernel/entry/syscall_user_dispatch.c:116:28: error: invalid application of 'sizeof' to incomplete type 'struct syscall_user_dispatch_config' 116 | if (size != sizeof(struct syscall_user_dispatch_config)) | ^~~~~~ >> kernel/entry/syscall_user_dispatch.c:114:45: warning: unused variable 'config' [-Wunused-variable] 114 | struct syscall_user_dispatch_config config; | ^~~~~~ kernel/entry/syscall_user_dispatch.c: In function 'syscall_user_dispatch_set_config': kernel/entry/syscall_user_dispatch.c:137:45: error: storage size of 'config' isn't known 137 | struct syscall_user_dispatch_config config; | ^~~~~~ kernel/entry/syscall_user_dispatch.c:139:28: error: invalid application of 'sizeof' to incomplete type 'struct syscall_user_dispatch_config' 139 | if (size != sizeof(struct syscall_user_dispatch_config)) | ^~~~~~ kernel/entry/syscall_user_dispatch.c:137:45: warning: unused variable 'config' [-Wunused-variable] 137 | struct syscall_user_dispatch_config config; | ^~~~~~ kernel/entry/syscall_user_dispatch.c:147:1: error: control reaches end of non-void function [-Werror=return-type] 147 | } | ^ cc1: some warnings being treated as errors vim +/config +114 kernel/entry/syscall_user_dispatch.c 109 110 int syscall_user_dispatch_get_config(struct task_struct *task, unsigned long size, 111 void __user *data) 112 { 113 struct syscall_user_dispatch *sd = &task->syscall_dispatch; > 114 struct syscall_user_dispatch_config config; 115 116 if (size != sizeof(struct syscall_user_dispatch_config)) 117 return -EINVAL; 118 119 if (test_syscall_work(SYSCALL_USER_DISPATCH)) 120 config.mode = PR_SYS_DISPATCH_ON; 121 else 122 config.mode = PR_SYS_DISPATCH_OFF; 123 124 config.offset = sd->offset; 125 config.len = sd->len; 126 config.selector = sd->selector; 127 128 if (copy_to_user(data, &config, sizeof(config))) 129 return -EFAULT; 130 131 return 0; 132 } 133 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
